Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): try talk to plaintext S2A if creds unavailable for mTLS-S2A #10941

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

xmenxk
Copy link
Contributor

@xmenxk xmenxk commented Oct 1, 2024

It's now possible to have S2A run on two ports, so updating the logic here to try second address if the first choice does not work (i.e. mTLS creds can not be loaded)

@xmenxk xmenxk requested a review from a team as a code owner October 1, 2024 23:05
@quartzmo quartzmo enabled auto-merge (squash) October 8, 2024 17:34
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2024
@quartzmo quartzmo merged commit 0f0bf2d into googleapis:main Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants